codeant-ai-for-open-source[bot] commented on PR #36937: URL: https://github.com/apache/superset/pull/36937#issuecomment-3717283976
## Nitpicks 🔍 <table> <tr><td>🔒 <strong>No security issues identified</strong></td></tr> <tr><td>⚡ <strong>Recommended areas for review</strong><br><br> - [ ] <a href='https://github.com/apache/superset/pull/36937/files#diff-b7dc9fa8d3969426f0aa364ad6169dfc9401554a5a568769f8dbf046e0d3e36fR169-R174'><strong>Unbounded row fetch risk</strong></a><br>When `include_raw_data` is true the code uses `request.limit or 100` as the `row_limit`. If clients pass a very large `limit` (or none is provided) this may return large datasets and cause heavy DB load / memory use. Consider enforcing a configurable hard cap or validating the requested limit.<br> - [ ] <a href='https://github.com/apache/superset/pull/36937/files#diff-c53108521a676f135ad7846c809dddc3eb33240abb7d123d0948cd5f7b2e9765R1117-R1130'><strong>Backward-incompatible schema change</strong></a><br>The `DataColumn` model now requires `sample_values`, `null_count`, and `unique_count` (no defaults). Making these fields required can cause validation errors where code paths / tests or existing responses construct chart data without those fields. This may break consumers that expect the previous, lighter-weight schema.<br> </td></tr> </table> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
