Vitor-Avila commented on code in PR #36937:
URL: https://github.com/apache/superset/pull/36937#discussion_r2668795281
##########
superset/mcp_service/chart/tool/get_chart_data.py:
##########
@@ -36,22 +36,30 @@
PerformanceMetadata,
)
from superset.mcp_service.utils.cache_utils import get_cache_status_from_result
+from superset.mcp_service.utils.schema_utils import parse_request
logger = logging.getLogger(__name__)
+# Maximum rows to prevent unbounded fetches and excessive memory/DB load
+MAX_ROW_LIMIT = 10000
+
Review Comment:
It's nice to have an override (like maybe when I'm talking to the MCP I
might say what are the top xxx from my chart so I don't need to bring all rows)
but if not provided, I wonder if we should just respect what's in the chart.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
