dimbleby commented on code in PR #36746: URL: https://github.com/apache/superset/pull/36746#discussion_r2669765866
########## RELEASING/README.md: ########## @@ -458,7 +458,7 @@ cd ../ sed -i '' "s/version_string = .*/version_string = \"$SUPERSET_VERSION\"/" setup.py Review Comment: I do not follow your line of thought. Is what not used any more? setup.py is still used, the sed command is just as useful / not-useful as ever it was. the difference is that - setup.py is not invoked _directly_, the `build` project takes care of it - and we build both a source distribution and a wheel -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
