richardfogaca commented on code in PR #35683:
URL: https://github.com/apache/superset/pull/35683#discussion_r2670272360
##########
superset-frontend/plugins/plugin-chart-ag-grid-table/src/AgGridTableChart.tsx:
##########
@@ -101,6 +111,29 @@ export default function TableChart<D extends DataRecord =
DataRecord>(
}
}, [columns]);
+ useEffect(() => {
Review Comment:
nit: this useEffect validates currentPage against totalPages, but having
serverPaginationData in deps means it runs on every pagination data change.
consider extracting currentPage and pageSize into stable references to reduce
effect triggers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
