richardfogaca commented on code in PR #35683:
URL: https://github.com/apache/superset/pull/35683#discussion_r2670286157
##########
superset-frontend/plugins/plugin-chart-ag-grid-table/src/AgGridTable/components/CustomHeader.tsx:
##########
@@ -106,14 +166,43 @@ const CustomHeader: React.FC<CustomHeaderParams> = ({
e.stopPropagation();
setFilterVisible(!isFilterVisible);
- const filterInstance = await api.getColumnFilterInstance<any>(column);
+ const filterInstance = (await api.getColumnFilterInstance(
+ column,
+ )) as AGGridFilterInstance | null;
const filterEl = filterInstance?.eGui;
if (filterEl && filterRef.current) {
filterRef.current.innerHTML = '';
filterRef.current.appendChild(filterEl);
}
};
+ /**
+ * Auto-open filter popover for the last filtered column after server data
refresh.
+ *
+ * The delay (FILTER_POPOVER_OPEN_DELAY) is necessary to:
Review Comment:
do we need all these comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
