codeant-ai-for-open-source[bot] commented on PR #36963: URL: https://github.com/apache/superset/pull/36963#issuecomment-3721509121
## Nitpicks 🔍 <table> <tr><td>🔒 <strong>No security issues identified</strong></td></tr> <tr><td>⚡ <strong>Recommended areas for review</strong><br><br> - [ ] <a href='https://github.com/apache/superset/pull/36963/files#diff-35372e3b3930efdf4a7f714a90a1e818b7964572bd3279892623269d69737172R770-R784'><strong>Overrides Prop</strong></a><br>The new hard-coded prop `dropdownAlign={DROPDOWN_ALIGN_BOTTOM}` is set after spreading `...props`, which unconditionally overrides any `dropdownAlign` provided by callers. This prevents consumers from customizing alignment and may be surprising or break integrations that rely on a different alignment.<br> - [ ] <a href='https://github.com/apache/superset/pull/36963/files#diff-32d64b815a8201c39288dc07b10a927d44ab056c2f4d51107233e4db696d198bR31-R35'><strong>Type / API mismatch</strong></a><br>The new `DROPDOWN_ALIGN_BOTTOM` object is likely intended for Ant Design / rc-trigger alignment APIs. The shape uses numeric values (0/1) for `overflow.adjustX`/`adjustY` which may not match the expected types (often booleans) or the library's AlignType. Confirm the runtime API accepts these values and add an explicit type to the constant to avoid subtle runtime behavior differences across environments.<br> </td></tr> </table> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
