bito-code-review[bot] commented on code in PR #36963:
URL: https://github.com/apache/superset/pull/36963#discussion_r2670567796
##########
superset-frontend/packages/superset-ui-core/src/components/Select/constants.ts:
##########
@@ -33,6 +33,12 @@ export const SELECT_ALL_VALUE: RawValue = t('Select All');
export const VIRTUAL_THRESHOLD = 20;
+export const DROPDOWN_ALIGN_BOTTOM = {
+ points: ['tl', 'bl'],
+ offset: [0, 4],
+ overflow: { adjustX: 0, adjustY: 1 },
+};
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Deprecated API Usage</b></div>
<div id="fix">
This constant defines a deprecated dropdownAlign configuration that's no
longer supported in Antd 5.26.0. The dropdownAlign prop was removed in favor of
the placement prop for better API consistency. Using placement="bottomLeft"
achieves the same bottom-left alignment without deprecated APIs.
</div>
</div>
<details>
<summary><b>Citations</b></summary>
<ul>
<li>
Rule Violated: <a
href="https://github.com/apache/superset/blob/3f38a44/.cursor/rules/dev-standard.mdc#L19";>dev-standard.mdc:19</a>
</li>
<li>
Rule Violated: <a
href="https://github.com/apache/superset/blob/3f38a44/AGENTS.md#L12";>AGENTS.md:12</a>
</li>
</ul>
</details>
<small><i>Code Review Run #6ec00e</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
