codeant-ai-for-open-source[bot] commented on PR #36986:
URL: https://github.com/apache/superset/pull/36986#issuecomment-3724998610

   ## Nitpicks 🔍
   
   <table>
   <tr><td>🔒&nbsp;<strong>No security issues identified</strong></td></tr>
   <tr><td>⚡&nbsp;<strong>Recommended areas for review</strong><br><br>
   
   - [ ] <a 
href='https://github.com/apache/superset/pull/36986/files#diff-d2c2b574ba7df0d5a3e5e5fa575a439625039505b1cd6878d865af76a85e8518R195-R197'><strong>Full
 page reload</strong></a><br>The code uses an anchor href to navigate to the 
databases list: using `href={ensureAppRoot('/databaseview/list')}` will trigger 
a full page reload instead of client-side navigation. Prefer using the app 
router (Link / navigate) so navigation stays within the SPA and preserves 
state/history.<br>
   
   </td></tr>
   </table>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to