geier commented on code in PR #36986:
URL: https://github.com/apache/superset/pull/36986#discussion_r2675296472
##########
superset-frontend/src/features/datasets/AddDataset/LeftPanel/index.tsx:
##########
@@ -191,7 +192,7 @@ export default function LeftPanel({
description={
<span>
{t('Manage your databases')}{' '}
- <Typography.Link href="/databaseview/list">
+ <Typography.Link href={ensureAppRoot('/databaseview/list')}>
Review Comment:
I have checked, and a lot of other existing links in the project use the
very same pattern as above, not the much more complicated (but more secure)
version you suggested. Can you check what the convention in the existing code
base is?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
