bito-code-review[bot] commented on code in PR #36644:
URL: https://github.com/apache/superset/pull/36644#discussion_r2674706094
##########
superset-frontend/src/SqlLab/components/SaveQuery/index.tsx:
##########
@@ -66,7 +66,6 @@ const Styles = styled.span`
span[role='img']:not([aria-label='down']) {
display: flex;
margin: 0;
- color: ${({ theme }) => theme.colorIcon};
svg {
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Icon color styling issue</b></div>
<div id="fix">
The removal of the color property from the span may cause icons in the save
query modal to lose their theme-based color, potentially making them invisible
or incorrectly colored. Based on similar patterns in the codebase, the color
should be applied to the svg element instead.
</div>
</div>
<details>
<summary><b>Citations</b></summary>
<ul>
<li>
Rule Violated: <a
href="https://github.com/apache/superset/blob/a5b30ad/AGENTS.md#L13";>AGENTS.md:13</a>
</li>
<li>
Rule Violated: <a
href="https://github.com/apache/superset/blob/a5b30ad/AGENTS.md#L14";>AGENTS.md:14</a>
</li>
</ul>
</details>
<small><i>Code Review Run #dd9e59</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
