michael-s-molina commented on code in PR #36644:
URL: https://github.com/apache/superset/pull/36644#discussion_r2675977875
##########
superset-frontend/src/components/ViewListExtension/index.tsx:
##########
@@ -16,18 +16,19 @@
* specific language governing permissions and limitations
* under the License.
*/
+import ExtensionsManager from 'src/extensions/ExtensionsManager';
+import { useExtensionsContext } from 'src/extensions/ExtensionsContext';
-/**
- * Jest configuration for @storybook/test-runner
- *
- * This extends the default test-runner config with custom timeouts
- * to handle slow story rendering in CI environments.
- */
-const { getJestConfig } = require('@storybook/test-runner');
-const testRunnerConfig = getJestConfig();
+export interface ViewExtensionProps {
+ viewId: string;
+}
-module.exports = {
- ...testRunnerConfig,
- // Increase timeout from default 15s to 60s for CI environments
- testTimeout: 60000,
+const ViewExtension = ({ viewId }: ViewExtensionProps) => {
+ const contributions =
+ ExtensionsManager.getInstance().getViewContributions(viewId) || [];
+ const { getView } = useExtensionsContext();
+
+ return <>{contributions.map(contribution => getView(contribution.id))}</>;
Review Comment:
Great Bito suggestion. @justinpark
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
