codeant-ai-for-open-source[bot] commented on PR #37034: URL: https://github.com/apache/superset/pull/37034#issuecomment-3734364132
## Nitpicks 🔍 <table> <tr><td>🔒 <strong>No security issues identified</strong></td></tr> <tr><td>⚡ <strong>Recommended areas for review</strong><br><br> - [ ] <a href='https://github.com/apache/superset/pull/37034/files#diff-e246a661203299ae44d3562a2b6c98e785b0878e825598eb24178bc018215447R176-R184'><strong>Possible Bug</strong></a><br>The new rules use the CSS variable `--ifm-font-color-base` which is not defined in the file (the project defines `--ifm-font-base-color` / `--ifm-font-base-color-inverse`). Using a non-existent variable will result in the color not resolving in browsers. Confirm the intended variable and update to the correct name or provide a fallback.<br> - [ ] <a href='https://github.com/apache/superset/pull/37034/files#diff-e1517a6522079eb97ad8178733f3673686a006ccec654d3c68f2e338ccd7c58dR105-R107'><strong>Accessibility / Contrast</strong></a><br>Explicitly setting label color may produce insufficient contrast in some theme combinations. Confirm the chosen token meets WCAG contrast for bold text at the used font size or switch to a high-contrast token.<br> - [ ] <a href='https://github.com/apache/superset/pull/37034/files#diff-e246a661203299ae44d3562a2b6c98e785b0878e825598eb24178bc018215447R176-R184'><strong>Icon color not applied</strong></a><br>Applying `color` to the `.ant-collapse-expand-icon` selector may not affect SVG icons used by Ant Design. SVG icons often require `fill`/`stroke` or `currentColor` usage. Verify the icon structure and ensure `fill`/`stroke` or more specific selectors are used so arrows actually change color in dark mode.<br> - [ ] <a href='https://github.com/apache/superset/pull/37034/files#diff-e1517a6522079eb97ad8178733f3673686a006ccec654d3c68f2e338ccd7c58dR105-R105'><strong>Color consistency</strong></a><br>The label color was set inline to `var(--ifm-font-color-base)`. Verify this variable produces the expected color in both light and dark themes, and confirm other UI elements (section arrows, card text, links) were updated consistently so there are no mixed-theme visuals.<br> </td></tr> </table> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
