codeant-ai-for-open-source[bot] commented on code in PR #37034:
URL: https://github.com/apache/superset/pull/37034#discussion_r2679415605
##########
docs/src/styles/custom.css:
##########
@@ -173,3 +173,12 @@ ul.dropdown__menu svg {
[data-theme='dark'] .alert--resources a {
color: var(--ifm-color-primary-light);
}
+
+/* Fix Ant Design Collapse arrow visibility in dark mode */
+[data-theme='dark'] .ant-collapse-expand-icon {
+ color: var(--ifm-font-color-base);
+}
+
+[data-theme='dark'] .ant-collapse-header {
+ color: var(--ifm-font-color-base);
Review Comment:
**Suggestion:** The rules use an undefined CSS variable
`--ifm-font-color-base` (typo); this will evaluate to nothing so the
icon/header won't receive the intended color—use the correct variable
`--ifm-font-base-color`. [possible bug]
**Severity Level:** Critical 🚨
```suggestion
color: var(--ifm-font-base-color);
}
[data-theme='dark'] .ant-collapse-header {
color: var(--ifm-font-base-color);
```
<details>
<summary><b>Why it matters? ⭐ </b></summary>
The PR defines --ifm-font-base-color in :root but the new rules reference
--ifm-font-color-base which doesn't exist, so the styles will not apply as
intended. Replacing the variable name fixes a real bug (missing color in dark
mode) with no side effects.
</details>
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** docs/src/styles/custom.css
**Line:** 179:183
**Comment:**
*Possible Bug: The rules use an undefined CSS variable
`--ifm-font-color-base` (typo); this will evaluate to nothing so the
icon/header won't receive the intended color—use the correct variable
`--ifm-font-base-color`.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
