amaannawab923 commented on PR #35683:
URL: https://github.com/apache/superset/pull/35683#issuecomment-3737857032
> 2 ideas for future improvements:
>
> 1. Perhaps `View query` should include the table filters?
> 2. Changing a page or setting a filter reloads the whole chart component.
It would be a much better user experience if we didn't completely unmount the
table, but instead display a loading spinner inside the table
Thanks for these suggestions, @kgabryje ! Both are great ideas for future
improvements.
1. "View Query" including table filters - Agreed, this would be a valuable
addition. We can look into including the applied filter clauses in the query
view.
2. Avoiding full component reload on page/filter changes - This is
something i explored but unfortunately couldn't implement in the current PR.
The challenge is that the Superset plugin architecture unmounts and re-renders
the entire chart component whenever a new API call is triggered. This means the
AG Grid instance gets destroyed and recreated on each request, making it
difficult to show an in-table loading spinner while preserving the existing
table state.
Addressing this would require changes at the Superset plugin/chart
rendering level to support partial updates without full unmounts , which is
beyond the scope of this PR but definitely worth exploring as a follow-up.
I'll add both of these as candidates for future improvements. Thanks again
for the thoughtful feedback!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
