geido commented on code in PR #37165:
URL: https://github.com/apache/superset/pull/37165#discussion_r2698271398
##########
superset-frontend/src/components/Datasource/components/DatasourceEditor/DatasourceEditor.jsx:
##########
@@ -314,12 +314,12 @@ function ColumnCollectionTable({
fieldKey="type"
label={t('Data type')}
control={
- <Select
+ <SelectControl
Review Comment:
I am not sure I am clear about why `Select` would not handle this properly.
The `Field` component should care about the label to be displayed and the
Select should work ok with this too. Is there a deeper issue going on in the
components?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
