massucattoj commented on code in PR #37165:
URL: https://github.com/apache/superset/pull/37165#discussion_r2704637304
##########
superset-frontend/src/components/Datasource/components/DatasourceEditor/DatasourceEditor.jsx:
##########
@@ -314,12 +314,12 @@ function ColumnCollectionTable({
fieldKey="type"
label={t('Data type')}
control={
- <Select
+ <SelectControl
Review Comment:
Looking a little bit deeper and yes, the `Field`component correctly passes
the `label` prop to child. However, the raw `Select` component uses a `header`
prop for displaying labels, not a label. The SelectControl wrapper handles this
by converting the label prop into a ControlHeader and passing it as the header
prop that Select expects.
But yes there is a way to keep the `Select` component here, that is add this
header prop. I'll use the old component with the new prop
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
