bito-code-review[bot] commented on code in PR #37214: URL: https://github.com/apache/superset/pull/37214#discussion_r2700241706
########## superset/mcp_service/mcp_config.py: ########## @@ -27,10 +27,10 @@ # MCP Service Configuration # Note: MCP_DEV_USERNAME MUST be configured in superset_config.py # There is no default value - the service will fail if not set -SUPERSET_WEBSERVER_ADDRESS = "http://localhost:9001"; +SUPERSET_WEBSERVER_ADDRESS = "http://localhost:9081"; Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Documentation inconsistency</b></div> <div id="fix"> The default SUPERSET_WEBSERVER_ADDRESS changed from port 9001 to 9081, but README.md still shows 9001 in examples. This creates inconsistency for users following documentation. </div> </div> <small><i>Code Review Run #9f052d</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/mcp_service/chart/validation/runtime/__init__.py: ########## @@ -38,16 +37,21 @@ class RuntimeValidator: @staticmethod def validate_runtime_issues( config: ChartConfig, dataset_id: int | str - ) -> Tuple[bool, ChartGenerationError | None]: + ) -> Tuple[bool, Dict[str, Any] | None]: Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Breaking API Change</b></div> <div id="fix"> The function signature change from returning an error to a warnings dict breaks existing tests in test_runtime_validator.py, which still unpack and assert on the old error format. This will cause test failures, preventing merge. </div> </div> <small><i>Code Review Run #9f052d</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
