aminghadersohi commented on PR #37214:
URL: https://github.com/apache/superset/pull/37214#issuecomment-3762215631
## Resolved All Review Comments
All 3 Bito review comments have been addressed in commit bd51979:
### 1. ✅ Assert replaced with proper exception (generate_chart.py:160)
```python
if validation_result.error is None:
raise RuntimeError("Validation failed but error object is missing")
```
### 2. ✅ Port reverted to 9001 (mcp_config.py:30)
Reverted from 9081 back to 9001 for documentation consistency.
### 3. ✅ Tests updated for new API (runtime/__init__.py:40)
All 7 tests in test_runtime_validator.py updated to expect warnings metadata
dict instead of None. Tests now pass.
---
CI is green: all modified lines covered, unit tests passing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
