Vitor-Avila commented on PR #37298: URL: https://github.com/apache/superset/pull/37298#issuecomment-3838972045
Hey @justinpark, Thanks for working on this update, SQL Lab is looking pretty nice! One thing I wanted to check with you is about the OAuth2 error flow. In the old layout, we would display a warning in the catalog/schema/table selectors and/or in the Results pane. With the new UI, the error message might take too much space: https://github.com/user-attachments/assets/647351f7-d92e-4fff-a111-4fa1e04af1aa Also, after clicking on the link and going through the auth flow, the user gets redirected back but triggering a refresh (which should clear the error message) is difficult due to the message length. Also, clearing the message at the popup doesn't clear it at the DB selector: https://github.com/user-attachments/assets/c8f2f939-76e7-428f-8f88-486ca6a1ac92 Any ideas on how to better display this error? Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
