kasiazjc commented on PR #37298: URL: https://github.com/apache/superset/pull/37298#issuecomment-3853973820
> @kasiazjc My concern with displaying global errors inline is that it introduces unnecessary complexity and can result in users seeing the same error message in multiple places. For instance, if there’s a lost connection or missing authentication credentials, showing inline errors would mean that every section relying on a connection or authentication—potentially 10+ locations—would display a "Connection error" or "Failed to authenticate" message. I believe this is exactly why Ant Design offers an error Notification component. In my view, inline errors make sense for non-global issues only. > > <img alt="Screenshot 2026-02-05 at 11 02 43" width="1912" height="852" src="https://private-user-images.githubusercontent.com/70410625/545630082-bf64ccd5-c7aa-456e-8200-2b5e9a5c009e.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzAzMDExNjMsIm5iZiI6MTc3MDMwMDg2MywicGF0aCI6Ii83MDQxMDYyNS81NDU2MzAwODItYmY2NGNjZDUtYzdhYS00NTZlLTgyMDAtMmI1ZTlhNWMwMDllLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjAyMDUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwMjA1VDE0MTQyM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTgzOGFjMjFkMGYyYzUxNDQ4ODJkNmExYWExNTlkYTg3ZDM2ZjZhZTI1MzI2ZmIwZjZlMmE2OTQyZGE1MzEzNzUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.fkya9xn77U7QOYrS8-PvCRjpDo1fenGmwxf0vR1lE_c";> That makes sense to me - let's ignore my combined error idea :D With notification error I am worried though that it's not that "in your face" - that's why my personal preference and sweet spot is banner/alert. Hard to miss and details are on hand (also if text will be longer) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://private-user-images.githubusercontent.com/70410625/545630082-bf64ccd5-c7aa-456e-8200-2b5e9a5c009e.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzAzMDExNjMsIm5iZiI6MTc3MDMwMDg2MywicGF0aCI6Ii83MDQxMDYyNS81NDU2MzAwODItYmY2NGNjZDUtYzdhYS00NTZlLTgyMDAtMmI1ZTlhNWMwMDllLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjAyMDUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwMjA1VDE0MTQyM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTgzOGFjMjFkMGYyYzUxNDQ4ODJkNmExYWExNTlkYTg3ZDM2ZjZhZTI1MzI2ZmIwZjZlMmE2OTQyZGE1MzEzNzUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.fkya9xn77U7QOYrS8-PvCRjpDo1fenGmwxf0vR1lE_c"](https://private-user-images.githubusercontent.com/70410625/545630082-bf64ccd5-c7aa-456e-8200-2b5e9a5c009e.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzAzMDExNjMsIm5iZiI6MTc3MDMwMDg2MywicGF0aCI6Ii83MDQxMDYyNS81NDU2MzAwODItYmY2NGNjZDUtYzdhYS00NTZlLTgyMDAtMmI1ZTlhNWMwMDllLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjAyMDUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwMjA1VDE0MTQyM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTgzOGFjMjFkMGYyYzUxNDQ4ODJkNmExYWExNTlkYTg3ZDM2ZjZhZTI1MzI2ZmIwZjZlMmE2OTQyZGE1MzEzNzUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.fkya9xn77U7QOYrS8-PvCRjpDo1fenGmwxf0vR1lE_c"){kind=link}