betodealmeida commented on code in PR #34826:
URL: https://github.com/apache/superset/pull/34826#discussion_r2765148765
##########
superset/models/core.py:
##########
@@ -421,130 +416,31 @@ def get_effective_user(self, object_url: URL) -> str |
None:
)
@contextmanager
- def get_sqla_engine( # pylint: disable=too-many-arguments
+ def get_sqla_engine(
self,
catalog: str | None = None,
schema: str | None = None,
- nullpool: bool = True,
Review Comment:
No, that's the default now, and if the admin wants something different they
need to specify pool options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
