betodealmeida commented on PR #34826: URL: https://github.com/apache/superset/pull/34826#issuecomment-3849883121
@villebro @michael-s-molina I understand this is not a solution for every deployment out there, but it's still incredibly valuable for other architectures (like Preset, but also smaller Superset deployments). For distributed workers you can continue using `EngineModes.NEW`, or potentially implement a third engine mode that manages the pool between pods. Regardless, IMHO this PR is a big win just for the fact that it centralizes the engine creation in a single place in a Flask extension. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
