rusackas commented on code in PR #37625:
URL: https://github.com/apache/superset/pull/37625#discussion_r2766078030
##########
superset-frontend/.eslintrc.js:
##########
@@ -273,6 +273,20 @@ module.exports = {
],
},
overrides: [
+ // Ban JavaScript files in src/ - all new code must be TypeScript
+ {
+ files: ['src/**/*.js', 'src/**/*.jsx'],
+ rules: {
+ 'no-restricted-syntax': [
+ 'error',
+ {
+ selector: 'Program',
+ message:
+ 'JavaScript files are not allowed in src/. Please use TypeScript
(.ts/.tsx) instead.',
+ },
+ ],
+ },
Review Comment:
ll .js/.jsx files in src/ were migrated to TypeScript as part of this PR.
That's the whole point. The eslint rule is a guardrail to prevent regression
after merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
