rusackas commented on code in PR #37625:
URL: https://github.com/apache/superset/pull/37625#discussion_r2767196790
##########
superset-frontend/plugins/legacy-plugin-chart-map-box/src/ScatterPlotGlowOverlay.tsx:
##########
@@ -234,23 +288,32 @@ class ScatterPlotGlowOverlay extends PureComponent {
}
} else {
const defaultRadius = radius / 6;
- const radiusProperty = location.properties.radius;
- const pointMetric = location.properties.metric;
- let pointRadius =
- radiusProperty === null ? defaultRadius : radiusProperty;
- let pointLabel;
-
- if (radiusProperty !== null) {
- const pointLatitude = lngLatAccessor(location)[1];
+ const radiusProperty = location.properties.radius as
+ | number
+ | null
+ | undefined;
+ const pointMetric = location.properties.metric as
+ | number
+ | string
+ | null;
+ // Handle both null and undefined as "missing" - use default radius
+ let pointRadius: number =
+ radiusProperty == null
+ ? defaultRadius
+ : (radiusProperty as number);
Review Comment:
Fixed! Good suggestion, as always :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
