bito-code-review[bot] commented on code in PR #35897:
URL: https://github.com/apache/superset/pull/35897#discussion_r2790461947
##########
superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx:
##########
@@ -934,18 +939,43 @@ export default function TableChart<D extends DataRecord =
DataRecord>(
formatter.getColorFromValue(valueToFormat);
if (!formatterResult) return;
- if (formatter.toTextColor) {
+ if (
+ formatter.objectFormatting === ObjectFormattingEnum.TEXT_COLOR
+ ) {
color = formatterResult.slice(0, -2);
+ } else if (
+ formatter.objectFormatting === ObjectFormattingEnum.CELL_BAR
+ ) {
+ if (showCellBars)
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Logic Inconsistency</b></div>
<div id="fix">
The CELL_BAR formatting checks only showCellBars, but valueRange uses
config.showCellBars ?? showCellBars. This inconsistency could cause CELL_BAR
colors to be set even when cell bars are disabled per column config, leading to
incorrect display.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
````suggestion
if (config.showCellBars ?? showCellBars)
````
</div>
</details>
</div>
<div><details><summary><b>Review Rule</b></summary><div>Bito created the
rule <strong><code>Inconsistent Configuration Override Logic</code></strong>
for <strong>repo:</strong> <code>apache/superset</code>,
<strong>language:</strong> <code>TSX</code>. Bito will avoid suggestions that
match this rule. You can manage review rules <a
href=https://alpha.bito.ai/home/ai-agents/review-rules>here</a>.</div></details></div>
<small><i>Code Review Run #b58c84</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
