bito-code-review[bot] commented on code in PR #35897:
URL: https://github.com/apache/superset/pull/35897#discussion_r2790505503
##########
superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx:
##########
@@ -934,18 +939,43 @@ export default function TableChart<D extends DataRecord =
DataRecord>(
formatter.getColorFromValue(valueToFormat);
if (!formatterResult) return;
- if (formatter.toTextColor) {
+ if (
+ formatter.objectFormatting === ObjectFormattingEnum.TEXT_COLOR
+ ) {
color = formatterResult.slice(0, -2);
+ } else if (
+ formatter.objectFormatting === ObjectFormattingEnum.CELL_BAR
+ ) {
+ if (showCellBars)
Review Comment:
<!-- Bito Reply -->
The suggestion to use `config.showCellBars ?? showCellBars` simplifies the
conditional check and is correct. The bar color is set when the showCellBars
flag is enabled and ObjectFormattingEnum.CELL_BAR is selected, as handled in
the formatter logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
