kgabryje opened a new pull request, #37941:
URL: https://github.com/apache/superset/pull/37941
### SUMMARY
The `GET /api/v1/dashboard/{id}` endpoint computes thumbnail_url in its
response, which triggers `get_dashboard_digest() → _adjust_string_with_rls()`.
This evaluates RLS filters for every unique datasource in the dashboard, adding
significant latency when there are many RLS filters.
The thumbnail_url is unnecessary on the detail endpoint (you don't need a
thumbnail of the dashboard you're already viewing) so it is safe to remove it
from the schema.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
Call GET /api/v1/dashboard/{id} and confirm the response no longer includes
thumbnail_url
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
