Vitor-Avila commented on PR #37941:
URL: https://github.com/apache/superset/pull/37941#issuecomment-3893040237
Talked with @kgabryje here, we might need to change the approach as the
Dashboards list uses `thumbnail_url` for `CardView`.
One thing I was thinking, is that currently:
1. The Dashboards list on `ListView` loads with `select_columns` to avoid
including `thumbnail_url` (for performance reasons).
2. When switching to `CardView`, a new request fires to
`/api/v1/dashboard/{id}` for each item in the list, so that `thumbnail_url` is
available.
At least on my end, when I change from `ListView` to `CardView`, the
thumbnails don't really load, unsure if this flow is working properly or not.
One suggestion: Could we change the process so that when switching to
`CardView`, we trigger a new call to `/api/v1/dashboard/` with `select_columns`
this time including `thumbnail_url`? It would:
1. Reduce the amount of API calls (get a list as opposed to one per item)
2. Allow us to remove the `thumbnail_url` from `/api/v1/dashboard/{id}`
Other pending question here is that if `thumbnail_url` is used anywhere else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
