EnxDev commented on code in PR #35897:
URL: https://github.com/apache/superset/pull/35897#discussion_r2807785559
##########
superset-frontend/src/explore/components/controls/ConditionalFormattingControl/FormattingPopoverContent.tsx:
##########
@@ -37,10 +37,21 @@ import {
Checkbox,
type FormProps,
} from '@superset-ui/core/components';
+import { ConditionalFormattingConfig, ColumnOption } from './types';
import {
- ConditionalFormattingConfig,
- ConditionalFormattingFlag,
-} from './types';
+ operatorOptions,
+ stringOperatorOptions,
+ booleanOperatorOptions,
+ formattingOptions,
+ colorSchemeOptions,
+} from './constants';
+
+// TODO: tangled redefinition that aligns with @superset-ui/plugin-chart-table
+// used to be imported but main app shouldn't depend on plugins...
+export enum ColorSchemeEnum {
+ 'Green' = 'Green',
+ 'Red' = 'Red',
+}
Review Comment:
Would it make sense to move this inside `./costants.ts` file?
##########
superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx:
##########
@@ -968,6 +998,7 @@ export default function TableChart<D extends DataRecord =
DataRecord>(
text-align: ${sharedStyle.textAlign};
white-space: ${value instanceof Date ? 'nowrap' : undefined};
position: relative;
+ font-weight: ${color ? `bold` : 'normal'};
Review Comment:
What do you think to use antd token here like `theme.fontWeightStrong` for
example?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
