SBIN2010 commented on code in PR #35897:
URL: https://github.com/apache/superset/pull/35897#discussion_r2807849908
##########
superset-frontend/src/explore/components/controls/ConditionalFormattingControl/FormattingPopoverContent.tsx:
##########
@@ -37,10 +37,21 @@ import {
Checkbox,
type FormProps,
} from '@superset-ui/core/components';
+import { ConditionalFormattingConfig, ColumnOption } from './types';
import {
- ConditionalFormattingConfig,
- ConditionalFormattingFlag,
-} from './types';
+ operatorOptions,
+ stringOperatorOptions,
+ booleanOperatorOptions,
+ formattingOptions,
+ colorSchemeOptions,
+} from './constants';
+
+// TODO: tangled redefinition that aligns with @superset-ui/plugin-chart-table
+// used to be imported but main app shouldn't depend on plugins...
+export enum ColorSchemeEnum {
+ 'Green' = 'Green',
+ 'Red' = 'Red',
+}
Review Comment:
Need to merge with the master, it's already pre-rebased in PR
https://github.com/apache/superset/pull/37591
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
