veeceey commented on code in PR #37975:
URL: https://github.com/apache/superset/pull/37975#discussion_r2808485797
##########
superset-frontend/src/components/Chart/DrillDetail/DrillDetailPane.test.tsx:
##########
@@ -189,6 +189,23 @@ test('should render the error', async () => {
expect(screen.getByText('Error: Something went wrong')).toBeInTheDocument();
});
+test('should only allow page size of 50 in pagination', async () => {
+ fetchWithData();
+ await waitForRender();
+ // The page size selector should only show 50 as an option
+ const pageSizeSelector = document.querySelector(
+ '.ant-pagination-options .ant-select-selection-item',
+ );
+ if (pageSizeSelector) {
+ expect(pageSizeSelector.textContent).toContain('50');
+ }
Review Comment:
Good catch — fixed in the latest push. The test now explicitly asserts that
the selector exists before checking its text, so a missing pagination element
will properly fail the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
