veeceey commented on PR #37975:
URL: https://github.com/apache/superset/pull/37975#issuecomment-3931854321
Reworked the pagination to follow the existing pattern as suggested by
@alexandrusoare.
**Changes:**
- Renamed `PAGE_SIZE` to `DEFAULT_PAGE_SIZE` (50 remains the default)
- Added dynamic `pageSize` state so users can choose from the standard page
size options (5, 15, 25, 50, 100) — consistent with other paginated components
like `DatasetPanel`
- Removed the `pageSizeOptions={[String(PAGE_SIZE)]}` lock that restricted
the selector to a single option
- The `onChange` handler now detects page size changes, clears the cached
results, and resets to page 1 when the user selects a different page size
- Updated the test to verify pagination renders with the default page size
without asserting that other options are absent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
