Vitor-Avila commented on PR #38015: URL: https://github.com/apache/superset/pull/38015#issuecomment-3912306938
Hey @kgabryje thanks for working on this! Few questions: 1. I believe the solution here is just removing it from the output/response, but not really excluding it from the actual DB query. This is similar to the difference between `columns` and `select_columns` in the list menus, for example. To test this, I accessed `http://localhost:8088/api/v1/dashboard/3?q=(columns:!(id))` and then checked the DB logs on my end: ``` sql SELECT dashboards.uuid AS dashboards_uuid, dashboards.created_on AS dashboards_created_on, dashboards.changed_on AS dashboards_changed_on, dashboards.id AS dashboards_id, dashboards.dashboard_title AS dashboards_dashboard_title, dashboards.position_json AS dashboards_position_json, dashboards.description AS dashboards_description, dashboards.css AS dashboards_css, dashboards.theme_id AS dashboards_theme_id, dashboards.certified_by AS dashboards_certified_by, dashboards.certification_details AS dashboards_certification_details, dashboards.json_metadata AS dashboards_json_metadata, dashboards.slug AS dashboards_slug, dashboards.published AS dashboards_published, dashboards.is_managed_externally AS dashboards_is_managed_externally, dashboards.external_url AS dashboards_external_url, dashboards.created_by_fk AS dashboards_created_by_fk, dashboards.changed_by_fk AS dashboards_changed_by_fk 2026-02-17 02:05:00.850 | FROM dashboards LEFT OUTER JOIN (dashboard_user AS dashboard_user_1 JOIN ab_user ON ab_user.id = dashboard_user_1.user_id) ON dashboards.id = dashboard_user_1.dashboard_id LEFT OUTER JOIN (dashboard_roles AS dashboard_roles_1 JOIN ab_role ON ab_role.id = dashboard_roles_1.role_id) ON dashboards.id = dashboard_roles_1.dashboard_id ``` `thumbnail_url` is not included in the query which is great, but I wonder if we want to match `select_columns` here? 2. @dpgaspar question for you: native support for `select_columns` / `columns` isn't available in FAB yet for `/api/v1/{model}/{id}`, right? Do you think it makes more sense if this logic lives there? 3. Tested and confirmed this: _"Open dashboard list in Card view, verify that responses include thumbnail_url"_! 🙌 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
