madhushreeag commented on code in PR #37555:
URL: https://github.com/apache/superset/pull/37555#discussion_r2843323500
##########
superset-frontend/src/components/Datasource/components/CollectionTable/index.tsx:
##########
@@ -416,6 +435,16 @@ export default class CRUDCollection extends PureComponent<
}
: undefined;
+ // Build controlled pagination config
+ const paginationConfig: false | TablePaginationConfig | undefined =
+ pagination === false || pagination === undefined
+ ? pagination
+ : {
+ ...(typeof pagination === 'object' ? pagination : {}),
+ current: this.state.currentPage,
+ pageSize: this.state.pageSize,
Review Comment:
fixed -
1. Computes maxPage from the collection size
2. Clamps via Math.min(statePage, maxPage)
3. Passes the clamped currentPage to the pagination config
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
