madhushreeag commented on code in PR #37555:
URL: https://github.com/apache/superset/pull/37555#discussion_r2843333013
##########
superset-frontend/src/components/Datasource/components/DatasourceEditor/DatasourceEditor.tsx:
##########
@@ -2205,7 +2236,7 @@ class DatasourceEditor extends PureComponent<
</Fieldset>
</FormContainer>
}
- collection={sortedMetrics}
+ collection={filteredMetrics}
Review Comment:
fixed - now pass collection={sortedMetrics} (full list) with
filterTerm={metricSearchTerm} and filterFields={['metric_name',
'verbose_name']} for display-only filtering inside
CollectionTable. No metrics are dropped when editing during a search.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
