michael-s-molina opened a new pull request, #38395: URL: https://github.com/apache/superset/pull/38395
### SUMMARY Renames `SIGNAL_CACHE_CONFIG` to `DISTRIBUTED_COORDINATION_CONFIG` to establish a name aligned with the long-term direction of this configuration. #### Why `DISTRIBUTED_COORDINATION_CONFIG`? The name was chosen to reflect both current behavior and future direction: **Current use cases:** - Atomic distributed locking via Redis `SET NX EX` - Pub/sub messaging for real-time abort/completion notifications between workers **Planned use cases:** - Redis Streams for persistent event logs - A higher-level coordination service exposing standardized interfaces for all of the above under a single connection Several names were considered: | Candidate | Reason rejected | |---|---| | `SIGNAL_CACHE_CONFIG` | "Signal" is too narrow; "cache" is misleading — this is not a cache | | `MESSAGE_BROKER_CONFIG` | Biased toward pub/sub; doesn't capture locking or streams | | `EVENT_BROKER_CONFIG` | Same issue — locks aren't "events" | | `COORDINATION_CONFIG` | Accurate but drops the distributed context, which is intentional | | `DISTRIBUTED_CONFIG` | Too generic; doesn't signal purpose | | `DISTRIBUTED_BACKEND_CONFIG` | Describes role in the stack, not what it does | `DISTRIBUTED_COORDINATION_CONFIG` wins because: - **`DISTRIBUTED`** is not redundant — it communicates *why* this config exists (only relevant in a distributed deployment) - **`COORDINATION`** is the standard distributed systems term for this class of primitives; Apache ZooKeeper describes itself as "a centralized service for distributed coordination" - Together they accurately describe the config today and remain accurate as locks, pub/sub, and streams are unified under the planned service abstraction ### TESTING INSTRUCTIONS 1. Configure `DISTRIBUTED_COORDINATION_CONFIG` in `superset_config.py` (previously `SIGNAL_CACHE_CONFIG`) 2. Verify distributed locking and pub/sub abort notifications continue to work 3. Verify that omitting the config falls back gracefully to database-backed locking and polling ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
