rusackas opened a new pull request, #40123: URL: https://github.com/apache/superset/pull/40123
### SUMMARY TDD-first regression coverage for [#16141](https://github.com/apache/superset/issues/16141) (Aug 2021): exporting two datasets with the same `table_name` but different schemas (e.g. `prod.users` + `dev.users`) historically returned only one file because the export filename did not disambiguate the pair. The current `ExportDatasetsCommand` already produces `<table_name>_<id>.yaml`, so the original collision should no longer occur — but no test pinned the behavior, leaving the bug technically open and at risk of silent regression. This PR is a small experiment in a *test-PR-first* workflow: open a failing-or-passing test that encodes the bug's contract before doing any code changes. If CI passes, the bug is provably fixed and #16141 can close. If CI fails, the test documents exactly what still needs work for whoever picks up the fix. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A — test-only. ### TESTING INSTRUCTIONS ```bash pytest tests/unit_tests/datasets/commands/export_test.py::test_export_two_datasets_same_table_name_different_schema -xvs ``` The test creates two `SqlaTable` rows with identical `table_name="users"` and distinct schemas (`prod`, `dev`), runs `ExportDatasetsCommand._export` on each, and asserts: 1. The two emitted file paths are distinct (no filename collision). 2. Both emitted YAML payloads carry the correct `schema:` field — neither is silently overwritten. ### ADDITIONAL INFORMATION - [x] Has associated issue: Closes #16141 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
