bito-code-review[bot] commented on PR #40123:
URL: https://github.com/apache/superset/pull/40123#issuecomment-4453147629
<!-- Bito Reply -->
Yes, using `yaml.safe_load` would be a more robust alternative to string
splitting for parsing the YAML content, as it properly handles the structure
and avoids potential errors from manual splitting. However, since the current
approach works for this test's specific needs and isn't causing issues, it's
not urgent to change.
**tests/unit_tests/datasets/commands/export_test.py**
```
import yaml
# Alternative parsing
schemas_in_yaml = {yaml.safe_load(c)['schema'] for c in contents}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
