aminghadersohi commented on PR #40349: URL: https://github.com/apache/superset/pull/40349#issuecomment-4557404692
Addressed both bito suggestions: 1. **`_humanize_timestamp` duplication** (schemas.py) — consolidated into `superset/mcp_service/response_utils.py` in commit `4857deaa8f`. All schema files now import from that shared module. 2. **Unused `cols` parameter in `_serialize_tag`** (list_tags.py) — renamed to `_cols` in commit `a9ef81a3fe` to signal it is intentionally unused. The parameter is required to satisfy the `ModelListCore` `item_serializer: Callable[[T, List[str]], S | None]` interface; the tag serializer handles all columns at once via `serialize_tag_object`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
