aminghadersohi commented on PR #40349: URL: https://github.com/apache/superset/pull/40349#issuecomment-4565829484
One small schema gap worth addressing before merge: **`TagInfo` missing `created_on` / `created_on_humanized`** The Tag model has `AuditMixinNullable` so both `created_on` and `changed_on` are available. The schema includes `changed_on` and `changed_on_humanized` but omits `created_on`. All sibling schemas in the suite include both timestamps. Recommend adding `created_on: str | datetime | None` and `created_on_humanized: str | None` to `TagInfo` and `serialize_tag_object` for consistency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
