aminghadersohi commented on PR #40344:
URL: https://github.com/apache/superset/pull/40344#issuecomment-4559799228
Good catch @richardfogaca — fixed in
8a84b91f89e021d8d0248542c9075eb152f25a25.
`_apply_config_guards` now imports `feature_flag_manager` from
`superset.extensions` and calls
`feature_flag_manager.is_feature_enabled("GLOBAL_TASK_FRAMEWORK")`, matching
`initialization/__init__.py` exactly. This respects `DEFAULT_FEATURE_FLAGS`,
`GET_FEATURE_FLAGS_FUNC`, `IS_FEATURE_ENABLED_FUNC`, and other Superset
enablement paths.
Test update: swapped the raw `FEATURE_FLAGS` config dict approach for a
`pytest` fixture (`gtf_ffm`) that patches
`superset.extensions.feature_flag_manager` — the one disabled-behavior test
overrides `is_feature_enabled.return_value = False` directly on that mock.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
