aminghadersohi commented on PR #40344: URL: https://github.com/apache/superset/pull/40344#issuecomment-4565401598
Thanks for the continued review, @richardfogaca! **Round 3 fixes — eeb4f0fe60:** **Issue A — dttm string normalization in `ActionLogFilter`:** Added a `model_validator(mode="after")` to `ActionLogFilter` that parses ISO string `dttm` values into timezone-aware `datetime` objects before they reach the DAO. Pydantic's left-to-right union matching keeps strings as `str` when `str` appears before `datetime` in the union, so caller-supplied strings like `"2020-01-01T00:00:00"` would have reached the DAO as-is and caused a VARCHAR bind type mismatch on Postgres TIMESTAMP columns. Naive datetimes are treated as UTC (consistent with the existing 7-day default cutoff logic). Updated the corresponding test assertion to verify the normalized `datetime` value. **Issue B — action-log/task tools in generated instructions:** - Added `Action Logs` and `Task Management` sections to `get_default_instructions()` with bullet entries for all four tools. The existing per-line filter in `get_default_instructions` already strips bullet lines for any tool in the `disabled_tools` set, so those entries are automatically excluded when the tools are removed. - Changed `_apply_config_guards` to return the set of tool names it removed. `init_fastmcp_server` now merges that set with `MCP_DISABLED_TOOLS` before calling `get_default_instructions`, so config-guard removals also suppress the corresponding instruction lines. - Added test coverage: `test_no_disabled_tools_returns_full_instructions` now asserts all four new tool bullets are present in the full instructions; `test_config_guard_tools_excluded_from_instructions` verifies that action-log tools are passed to `get_default_instructions` in the `disabled_tools` set when `SUPERSET_LOG_VIEW=False`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
