aminghadersohi commented on code in PR #40340:
URL: https://github.com/apache/superset/pull/40340#discussion_r3315691513
##########
superset/mcp_service/dataset/schemas.py:
##########
@@ -324,6 +324,33 @@ class GetDatasetInfoRequest(MetadataCacheControl):
]
+class CreateDatasetRequest(BaseModel):
+ """Request schema for create_dataset to register a physical table as a
dataset."""
+
+ database_id: Annotated[
+ int,
+ Field(
+ description="ID of the database connection to register the table
against"
+ ),
+ ]
+ schema: Annotated[
+ str,
+ Field(description="Schema (namespace) where the table lives, e.g.
'public'"),
+ ]
Review Comment:
Fixed in commit 3c4396ae: `CreateDatasetRequest.schema` is now `str | None`
with `default=None`, so databases without schema namespaces (e.g. SQLite) can
register tables without hitting a validation error. Blank/whitespace-only
schema values are also normalized to `None` before forwarding to
`CreateDatasetCommand`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
