aminghadersohi commented on PR #40340: URL: https://github.com/apache/superset/pull/40340#issuecomment-4561929004
Thanks for the bito suggestions. Addressed in the latest commit (4faa3ae5): - **Missing test for `DatasetInvalidError`** → added `test_create_dataset_invalid_error` covering that handler path - **`table_name` missing `min_length=1`** → added, matching the pattern in `CreateVirtualDatasetRequest` The other notes (mock duplication with `test_dataset_tools.py`, function return-count) are style observations that don't affect correctness and are left for a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
