rusackas commented on PR #38119: URL: https://github.com/apache/superset/pull/38119#issuecomment-4736979941
@Vansh5632 CI's red across the board here - `lint-frontend`, jest, pre-commit, storybook all failing. Looks like `getLabelPositionOptions` is left orphaned in `controlPanel.tsx` once you swap to `RADAR_LABEL_POSITION`, and the new constants in `constants.ts` dropped the `t()` wrapping the old options had, so the labels won't translate anymore. But more importantly - @SBIN2010 pointed out back in March that ECharts radar actually supports all the label positions, and the real issue may just be `inside` being reversed. If that's right, removing the options is the wrong fix. Can you confirm against the [ECharts label-position example](https://echarts.apache.org/examples/en/view.html?c=doc-example/label-position) before we go further? Converting this to draft while it awaits touchups. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
