rusackas commented on PR #37794: URL: https://github.com/apache/superset/pull/37794#issuecomment-4736984385
@tiya-9975 thanks for taking the leap from docs into an actual `alignment` control, that's exactly the direction I was hoping for! Couple of things holding it up: - `lint-frontend`, `validate-frontend`, and `sharded-jest-tests (2)` are red on this PR's own code, and there's a leftover `// ✅ NEW PROP` comment in `types.ts` that pre-commit/eslint will trip on. Can you get CI green? - Now that the control exists, the UPDATING.md blurb still says alignment "is no longer configurable via chart controls" and points people at custom CSS, which contradicts the code. Mind reworking that into a note about the new control instead? - And as @sadpandajoe mentioned, this is no longer a `docs:` PR... can you retitle it to `feat:` since it adds a control? Converting this to draft for now while it awaits touchups. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
