bito-code-review[bot] commented on PR #41462:
URL: https://github.com/apache/superset/pull/41462#issuecomment-4813003529
<!-- Bito Reply -->
The comment is correct that the example `a.b`.`c` is confusing. The
intention of the code comment is to describe how `sqlglot` normalization can
incorrectly collapse a dotted path (like `a.b.c`) into a single quoted
identifier (e.g., `` `a.b.c` ``), which causes issues for databases like
BigQuery that require each segment to be quoted individually (e.g., ``
`a`.`b`.`c` ``). Updating the example to `a.b.c` would better illustrate the
problematic behavior being avoided.
**superset/models/helpers.py**
```
# Routing these through ``quote()`` + sqlglot normalization below
# can collapse the dotted path into a single quoted
identifier
# (e.g. `` `a.b.c` ``), which breaks drill to detail /
samples
# queries on nested columns (SC-111745).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
