Copilot commented on code in PR #41462:
URL: https://github.com/apache/superset/pull/41462#discussion_r3483810935
##########
superset/models/helpers.py:
##########
@@ -3350,6 +3350,23 @@ def get_sqla_query( # pylint:
disable=too-many-arguments,too-many-locals,too-ma
select_exprs.append(outer)
elif columns:
for selected in columns:
+ # Resolve a known column directly to its ``TableColumn`` so
that
+ # multi-part identifiers (e.g. a BigQuery STRUCT field
registered
+ # with a dotted ``column_name`` such as ``a.b.c``) are quoted
per
+ # segment, matching the chart/groupby selection path above.
+ # Routing these through ``quote()`` + sqlglot normalization
below
+ # can collapse the dotted path into a single quoted identifier
+ # (e.g. ```a.b`.`c```), which breaks drill to detail / samples
+ # queries on nested columns (SC-111745).
Review Comment:
The comment says sqlglot normalization can collapse a dotted path into a
*single* quoted identifier, but the example shown (```a.b`.`c```) is not a
single identifier. This is likely meant to illustrate the merged identifier
form (e.g. `a.b.c`), and the current example is confusing/misleading for future
readers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
