codeant-ai-for-open-source[bot] commented on code in PR #41590:
URL: https://github.com/apache/superset/pull/41590#discussion_r3507906281
##########
superset/semantic_layers/mapper.py:
##########
@@ -543,9 +546,9 @@ def _convert_query_object_filter(
if operator_str == FilterOperator.TEMPORAL_RANGE.value:
if not isinstance(value, str) or value == NO_TIME_RANGE:
return None
- start, end = (side.strip() for side in value.split(" : "))
+ start, end = get_since_until_from_time_range(time_range=value)
Review Comment:
**Suggestion:** Add explicit type annotations for the newly introduced
temporal boundary variables so the new logic follows the required typing rule
for annotatable variables. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
The rule requires type hints on relevant variables that can be annotated.
This new tuple assignment introduces two local variables with no explicit type
annotation, so the suggestion identifies a real typing omission.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=00c7c9b099404ca7adef22294d54f247&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=00c7c9b099404ca7adef22294d54f247&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/semantic_layers/mapper.py
**Line:** 549:549
**Comment:**
*Custom Rule: Add explicit type annotations for the newly introduced
temporal boundary variables so the new logic follows the required typing rule
for annotatable variables.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41590&comment_hash=e070592a7ceabed1c2fbe69182b92424993eed11311dfa6d6d069d6615eedd19&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41590&comment_hash=e070592a7ceabed1c2fbe69182b92424993eed11311dfa6d6d069d6615eedd19&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
