rusackas commented on code in PR #41590:
URL: https://github.com/apache/superset/pull/41590#discussion_r3524013961
##########
superset/semantic_layers/mapper.py:
##########
@@ -543,9 +546,9 @@ def _convert_query_object_filter(
if operator_str == FilterOperator.TEMPORAL_RANGE.value:
if not isinstance(value, str) or value == NO_TIME_RANGE:
return None
- start, end = (side.strip() for side in value.split(" : "))
+ start, end = get_since_until_from_time_range(time_range=value)
Review Comment:
No annotation needed here... `get_since_until_from_time_range` returns
`tuple[datetime | None, datetime | None]`, so mypy infers `start`/`end`
exactly. Python can't annotate tuple-unpack targets inline anyway, so
satisfying this would mean two pre-declaration lines that restate the
signature. This file only annotates locals where inference needs help
(`filters: set[Filter]`, the branch-widened `value`), and mypy/pre-commit are
green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
